From 6aea89d687884adfc69413c7692e4ccb991c2840 Mon Sep 17 00:00:00 2001
From: Ben Claussen <benclaussen@gmail.com>
Date: Mon, 21 May 2018 15:00:17 -0400
Subject: [PATCH] Change appropriate ADD to NEW commands -
 New-NetboxIPAMAddress - New-NetboxVirtualMachine

---
 Functions/IPAM/IPAM.ps1                     |  8 ++++----
 Functions/Virtualization/Virtualization.ps1 |  7 ++++---
 Tests/IPAM.Tests.ps1                        | 14 +++++++-------
 Tests/Virtualization.Tests.ps1              | 10 +++++-----
 4 files changed, 20 insertions(+), 19 deletions(-)

diff --git a/Functions/IPAM/IPAM.ps1 b/Functions/IPAM/IPAM.ps1
index 29ed607..b00ec08 100644
--- a/Functions/IPAM/IPAM.ps1
+++ b/Functions/IPAM/IPAM.ps1
@@ -414,13 +414,13 @@ function Get-NetboxIPAMPrefix {
     InvokeNetboxRequest -URI $uri -Raw:$Raw
 }
 
-function Add-NetboxIPAMAddress {
+function New-NetboxIPAMAddress {
 <#
     .SYNOPSIS
-        Add a new IP address to Netbox
+        Create a new IP address to Netbox
     
     .DESCRIPTION
-        Adds a new IP address to Netbox with a status of Active by default.
+        Create a new IP address to Netbox with a status of Active by default.
     
     .PARAMETER Address
         IP address in CIDR notation: 192.168.1.1/24
@@ -453,7 +453,7 @@ function Add-NetboxIPAMAddress {
         Return raw results from API service
     
     .EXAMPLE
-        PS C:\> Add-NetboxIPAMAddress
+        PS C:\> Create-NetboxIPAMAddress
     
     .NOTES
         Additional information about the function.
diff --git a/Functions/Virtualization/Virtualization.ps1 b/Functions/Virtualization/Virtualization.ps1
index 687970c..abb6dc2 100644
--- a/Functions/Virtualization/Virtualization.ps1
+++ b/Functions/Virtualization/Virtualization.ps1
@@ -459,9 +459,9 @@ function Get-NetboxVirtualizationClusterGroup {
 #endregion GET commands
 
 
-#region ADD commands
+#region ADD/NEW commands
 
-function Add-NetboxVirtualMachine {
+function New-NetboxVirtualMachine {
     [CmdletBinding()]
     [OutputType([pscustomobject])]
     param
@@ -577,7 +577,7 @@ function Set-NetboxVirtualMachine {
         [switch]$Force
     )
     
-    if ($Status) {
+    if ($null -ne $Status) {
         $PSBoundParameters.Status = VerifyVirtualizationChoices -ProvidedValue $Status -VirtualMachineStatus
     }
     
@@ -644,6 +644,7 @@ function Set-NetboxVirtualMachineInterface {
             }
         }
     }
+    
     end {
         
     }
diff --git a/Tests/IPAM.Tests.ps1 b/Tests/IPAM.Tests.ps1
index 942ed56..438f342 100644
--- a/Tests/IPAM.Tests.ps1
+++ b/Tests/IPAM.Tests.ps1
@@ -352,9 +352,9 @@ Describe -Name "IPAM tests" -Tag 'Ipam' -Fixture {
             }
         }
         
-        Context -Name "Add-NetboxIPAMAddress" -Fixture {
-            It "Should add a basic IP address" {
-                $Result = Add-NetboxIPAMAddress -Address '10.0.0.1/24'
+        Context -Name "New-NetboxIPAMAddress" -Fixture {
+            It "Should create a basic IP address" {
+                $Result = New-NetboxIPAMAddress -Address '10.0.0.1/24'
                 
                 Assert-VerifiableMock
                 
@@ -364,8 +364,8 @@ Describe -Name "IPAM tests" -Tag 'Ipam' -Fixture {
                 $Result.Body | Should -Be '{"status":1,"address":"10.0.0.1/24"}'
             }
             
-            It "Should add an IP with a status and role names" {
-                $Result = Add-NetboxIPAMAddress -Address '10.0.0.1/24' -Status 'Reserved' -Role 'Anycast'
+            It "Should create an IP with a status and role names" {
+                $Result = New-NetboxIPAMAddress -Address '10.0.0.1/24' -Status 'Reserved' -Role 'Anycast'
                 
                 Assert-VerifiableMock
                 
@@ -375,8 +375,8 @@ Describe -Name "IPAM tests" -Tag 'Ipam' -Fixture {
                 $Result.Body | Should -Be '{"status":2,"address":"10.0.0.1/24","role":30}'
             }
             
-            It "Should add an IP with a status and role values" {
-                $Result = Add-NetboxIPAMAddress -Address '10.0.1.1/24' -Status '1' -Role '10'
+            It "Should create an IP with a status and role values" {
+                $Result = New-NetboxIPAMAddress -Address '10.0.1.1/24' -Status '1' -Role '10'
                 
                 Assert-VerifiableMock
                 
diff --git a/Tests/Virtualization.Tests.ps1 b/Tests/Virtualization.Tests.ps1
index bdfff70..4d214ff 100644
--- a/Tests/Virtualization.Tests.ps1
+++ b/Tests/Virtualization.Tests.ps1
@@ -306,9 +306,9 @@ Describe -Name "Virtualization tests" -Tag 'Virtualization' -Fixture {
             }
         }
         
-        Context -Name "Add-NetboxVirtualMachine" -Fixture {
-            It "Should add a basic VM" {
-                $Result = Add-NetboxVirtualMachine -Name 'testvm' -Cluster 1
+        Context -Name "New-NetboxVirtualMachine" -Fixture {
+            It "Should create a basic VM" {
+                $Result = New-NetboxVirtualMachine -Name 'testvm' -Cluster 1
                 
                 Assert-VerifiableMock
 
@@ -318,8 +318,8 @@ Describe -Name "Virtualization tests" -Tag 'Virtualization' -Fixture {
                 $Result.Body | Should -Be '{"cluster":1,"name":"testvm","status":1}'
             }
             
-            It "Should add a VM with CPUs, Memory, Disk, tenancy, and comments" {
-                $Result = Add-NetboxVirtualMachine -Name 'testvm' -Cluster 1 -Status Active -vCPUs 4 -Memory 4096 -Tenant 11 -Disk 50 -Comments "these are comments"
+            It "Should create a VM with CPUs, Memory, Disk, tenancy, and comments" {
+                $Result = New-NetboxVirtualMachine -Name 'testvm' -Cluster 1 -Status Active -vCPUs 4 -Memory 4096 -Tenant 11 -Disk 50 -Comments "these are comments"
                 
                 Assert-VerifiableMock