From e2697e7addbfc3894fec16cb045a8f451dcb4c0a Mon Sep 17 00:00:00 2001 From: Pascal Liehne Date: Wed, 2 Oct 2024 22:27:13 +0200 Subject: [PATCH] Fix New-NetboxVirtualMachine: Site is not mandatory, but site or cluster must be set --- .../VirtualMachine/New-NetboxVirtualMachine.ps1 | 5 ++--- NetboxPS.psd1 | 2 +- NetboxPS/NetboxPS.psd1 | 2 +- NetboxPS/NetboxPS.psm1 | 5 ++--- 4 files changed, 6 insertions(+), 8 deletions(-) diff --git a/Functions/Virtualization/VirtualMachine/New-NetboxVirtualMachine.ps1 b/Functions/Virtualization/VirtualMachine/New-NetboxVirtualMachine.ps1 index f5eaebf..ac3b6d5 100644 --- a/Functions/Virtualization/VirtualMachine/New-NetboxVirtualMachine.ps1 +++ b/Functions/Virtualization/VirtualMachine/New-NetboxVirtualMachine.ps1 @@ -8,7 +8,6 @@ function New-NetboxVirtualMachine { [Parameter(Mandatory = $true)] [string]$Name, - [Parameter(Mandatory = $true)] [uint64]$Site, [uint64]$Cluster, @@ -45,8 +44,8 @@ function New-NetboxVirtualMachine { #$PSBoundParameters.Status = ValidateVirtualizationChoice -ProvidedValue $Status -VirtualMachineStatus - if ($PSBoundParameters.ContainsKey('Cluster') -and (-not $PSBoundParameters.ContainsKey('Site'))) { - throw "You must specify a site ID with a cluster ID" + if (-not $PSBoundParameters.ContainsKey('Cluster') -and (-not $PSBoundParameters.ContainsKey('Site'))) { + throw "A virtual machine must be assigned to a site and/or cluster." } $Segments = [System.Collections.ArrayList]::new(@('virtualization', 'virtual-machines')) diff --git a/NetboxPS.psd1 b/NetboxPS.psd1 index 22fc1f7..1402f62 100644 --- a/NetboxPS.psd1 +++ b/NetboxPS.psd1 @@ -3,7 +3,7 @@ # # Generated by: Ben Claussen # -# Generated on: 01/09/2024 +# Generated on: 10/2/2024 # @{ diff --git a/NetboxPS/NetboxPS.psd1 b/NetboxPS/NetboxPS.psd1 index 22fc1f7..1402f62 100644 --- a/NetboxPS/NetboxPS.psd1 +++ b/NetboxPS/NetboxPS.psd1 @@ -3,7 +3,7 @@ # # Generated by: Ben Claussen # -# Generated on: 01/09/2024 +# Generated on: 10/2/2024 # @{ diff --git a/NetboxPS/NetboxPS.psm1 b/NetboxPS/NetboxPS.psm1 index f8e63e0..f31c7b9 100644 --- a/NetboxPS/NetboxPS.psm1 +++ b/NetboxPS/NetboxPS.psm1 @@ -4502,7 +4502,6 @@ function New-NetboxVirtualMachine { [Parameter(Mandatory = $true)] [string]$Name, - [Parameter(Mandatory = $true)] [uint64]$Site, [uint64]$Cluster, @@ -4539,8 +4538,8 @@ function New-NetboxVirtualMachine { #$PSBoundParameters.Status = ValidateVirtualizationChoice -ProvidedValue $Status -VirtualMachineStatus - if ($PSBoundParameters.ContainsKey('Cluster') -and (-not $PSBoundParameters.ContainsKey('Site'))) { - throw "You must specify a site ID with a cluster ID" + if (-not $PSBoundParameters.ContainsKey('Cluster') -and (-not $PSBoundParameters.ContainsKey('Site'))) { + throw "A virtual machine must be assigned to a site and/or cluster." } $Segments = [System.Collections.ArrayList]::new(@('virtualization', 'virtual-machines'))